Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isCheckable from state prop #872

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

marcosrdz
Copy link
Contributor

if prop value for state is "on" or "off" then isCheckable = true and isChecked = menuState, otherwise isCheckable = false

@marcosrdz
Copy link
Contributor Author

@Naturalclar any chance of reviewing this?

Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the ping, LGTM!

@Naturalclar Naturalclar merged commit a149bbf into react-native-menu:master Sep 7, 2024
5 checks passed
Copy link

@colorado392 colorado392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants